-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dotenv to v3 #74
Conversation
I think this should result in a version 2.0 because of the backwards compatibility break. And also #72 need to be merged to make it Laravel 5.8 compatible. See: https://laravel.com/docs/5.8/upgrade#string-and-array-helpers |
Why not support both version? If It's very sketchy that you claim to support |
Updated with backward compatibility. CI is now passing against Laravel 5.6 and 5.8. It could probably be a minor release now. |
Maybe it is a good idea to create a PR to test for the different versions, but because #60 doesn't get any reaction I'm not sure that @mpociot will place some focus on testing as long as it works. @fitztrev good update. |
Thank you very much for the work on this! :) |
There's an incompatibility with Laravel 5.8 and this because of
vlucas/phpdotenv
between each's composer.json.laravel/framework
vlucas/phpdotenv
beyondcode/laravel-self-diagnosis
vlucas/phpdotenv
I know this PR's current state is not the best way to fix it (unless you want to release a new major version), as it will break backwards compatibility, but here's a first attempt to hopefully help at least get it started. This fixes it for 5.8.